Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option mempooltxinputlimit #4211

Merged
merged 1 commit into from Dec 3, 2019

Conversation

dagurval
Copy link
Contributor

@dagurval dagurval commented Nov 8, 2019

This option is no longer used after Overwinter. Fixes #4209.

@str4d str4d added C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-community-contribution Category: A contribution from the community! labels Nov 8, 2019
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like code removal PRs!

qa/rpc-tests/mergetoaddress_helper.py Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
@zkbot
Copy link
Contributor

zkbot commented Nov 11, 2019

☔ The latest upstream changes (presumably #4178) made this pull request unmergeable. Please resolve the merge conflicts.

This option is no longer used after Overwinter. Fixes zcash#4209.
@dagurval
Copy link
Contributor Author

Rebased

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d added this to the v2.1.1 milestone Nov 27, 2019
@mdr0id
Copy link
Contributor

mdr0id commented Dec 3, 2019

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

📌 Commit fe1ff82 has been approved by mdr0id

@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

⌛ Testing commit fe1ff82 with merge 2383d1b...

zkbot added a commit that referenced this pull request Dec 3, 2019
Remove option mempooltxinputlimit

This option is no longer used after Overwinter. Fixes #4209.
@zkbot
Copy link
Contributor

zkbot commented Dec 3, 2019

☀️ Test successful - pr-merge
Approved by: mdr0id
Pushing 2383d1b to master...

@zkbot zkbot merged commit fe1ff82 into zcash:master Dec 3, 2019
@dagurval dagurval deleted the rm-mempooltxinputlimit branch December 3, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-community-contribution Category: A contribution from the community!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mempooltxinputlimit
4 participants