Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spend_hash and output_hash from load_parameters() #4520

Closed
wants to merge 2 commits into from
Closed

Remove spend_hash and output_hash from load_parameters() #4520

wants to merge 2 commits into from

Conversation

therealyingtong
Copy link
Contributor

@therealyingtong therealyingtong commented May 11, 2020 •
edited

Closes #4519

@str4d str4d added A-rust-ffi Area: The Rust FFI in the librustzcash library. L-rust Involves Rust code. labels May 12, 2020
Remove circuit hashes from init_zksnark_params()
1ff3d24 
Remove spend_hash, output_hash, sprout_hash as arguments into the librustzcash function init_zksnark_params() and its caller librustzcash_init_zksnark_params()

Corresponding change proposed in librustzcash zcash#106.
@therealyingtong therealyingtong force-pushed the 4519-remove-sapling-circuit-hashes branch from bf6570c to 1ff3d24 Compare May 13, 2020 15:38
@str4d str4d added this to the Core Sprint 2020-33 milestone Aug 17, 2020
daira
daira approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@daira daira left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@daira
Copy link
Contributor

daira commented Aug 22, 2020

This is removing something that wasn't being used, so it cannot affect consensus. @zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Aug 22, 2020

📌 Commit 1ff3d24 has been approved by daira

@zkbot
Copy link
Contributor

zkbot commented Aug 22, 2020

⌛ Testing commit 1ff3d24 with merge c55a11679bec4596457b19345838ce8bd13b570e...

@zkbot
Copy link
Contributor

zkbot commented Aug 22, 2020

💔 Test failed - pr-merge

@daira
rustzcash.rs: remove unused imports.
643af1a 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
Copy link
Contributor

daira commented Aug 22, 2020

Ah, this requires bumping the dependency on the zcash_proofs crate (and therefore other crates in librustzcash).

@str4d
Copy link
Contributor

str4d commented Aug 25, 2020

Superceded by #4682.

@str4d str4d closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@ebfull ebfull ebfull approved these changes

@str4d str4d Awaiting requested review from str4d

Assignees
No one assigned
Labels
A-rust-ffi Area: The Rust FFI in the librustzcash library. L-rust Involves Rust code.
Projects
None yet
Milestone
Core Sprint 2020-33
Development

Successfully merging this pull request may close these issues.

Remove Sapling circuit hashes from load_parameters()
5 participants
@therealyingtong @daira @zkbot @str4d @ebfull