Skip to content
This repository was archived by the owner on Jul 19, 2026. It is now read-only.

Feature/wallet orchard UA RPCs - #5300

Merged
str4d merged 3 commits into
zcash:feature/wallet_unified_addressesfrom
LarryRuane:feature/wallet_orchard
Dec 20, 2021
Merged

Feature/wallet orchard UA RPCs#5300
str4d merged 3 commits into
zcash:feature/wallet_unified_addressesfrom
LarryRuane:feature/wallet_orchard

Conversation

@LarryRuane

@LarryRuane LarryRuane commented Sep 15, 2021 •
edited by str4d
Loading

Copy link
Copy Markdown
Collaborator

Changes to wallet RPC code for orchard / NU5.

Part of #5177.
Part of #5178.
Part of #5180.
Part of #5181.
Part of #5182.
Part of #5183.
Part of #5191.

daira
daira reviewed Sep 15, 2021
View reviewed changes
Comment thread src/rust/src/address_ffi.rs Outdated
@LarryRuane
LarryRuane force-pushed the feature/wallet_orchard branch from 9b3843f to b3c7a41 Compare September 15, 2021 14:45
@LarryRuane

LarryRuane commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator Author

Force-pushed to clean up ParseArbitraryInt() slightly, and add more tests.

@r3ld3v r3ld3v added this to the Core Sprint 2021-36 milestone Sep 15, 2021
@LarryRuane
LarryRuane force-pushed the feature/wallet_orchard branch from b3c7a41 to 294472d Compare September 23, 2021 14:59
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/test/util_tests.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Oct 4, 2021
View reviewed changes

@daira daira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, some minor comments.

daira
daira reviewed Dec 14, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Dec 14, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Dec 14, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira reviewed Dec 14, 2021
View reviewed changes
Comment thread src/wallet/rpcwallet.cpp Outdated
daira
daira approved these changes Dec 14, 2021
View reviewed changes

@daira daira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 44b0dc7e13e9741aca4033ac2e6b1c82e667ac06 with some more non-blocking suggestions.

@str4d

str4d commented Dec 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Blocking: Please rebase this PR to remove commit de1d41b, which should not be in the git history (it is the commit that was pushed directly to #5419, that I subsequently removed because it referred to a non-existent commit). This will also enable the most recent fixup commit (44b0dc7e13e9741aca4033ac2e6b1c82e667ac06) to be removed.

@LarryRuane
LarryRuane force-pushed the feature/wallet_orchard branch from 44b0dc7 to f21c0a4 Compare December 14, 2021 21:53
@LarryRuane

LarryRuane commented Dec 14, 2021

Copy link
Copy Markdown
Collaborator Author

Blocking: Please rebase this PR

Done, just force-pushed (to f21c0a49551a0abccd2efbe37f690e0d902c300f).

I'd like to do one more quick force-push for @daira's comments, they shouldn't take long.

@LarryRuane
LarryRuane force-pushed the feature/wallet_orchard branch from f21c0a4 to 296b743 Compare December 14, 2021 22:21
@LarryRuane

LarryRuane commented Dec 14, 2021

Copy link
Copy Markdown
Collaborator Author

Force-push (to 296b743cd6d397fc15ec3ce483d128806eeadcaa) to address Daira's review comments.

@str4d str4d mentioned this pull request Dec 14, 2021
Closed
str4d
str4d suggested changes Dec 15, 2021
View reviewed changes
Comment thread src/test/util_tests.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated

@str4d str4d Dec 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be unifiedaddress (i.e. specifically indicating it is a Unified Address), or could it just be address (leaving the address kind defined by the string encoding)? If the latter, then we could instead make this defaultaddress to convey the documented semantics.

Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/test/rpc_wallet_tests.cpp Outdated
Comment thread src/wallet/rpcwallet.cpp Outdated
@LarryRuane
Add new and modify existing Orchard RPCs, non-functional
f139cdc 
The new RPCs aren't functional, only have argument parsing and sample
outputs, guarded by experimental -orchardwallet flag.

These changes used the tickets linked from
zcash#5056 as a guide.
@LarryRuane
LarryRuane force-pushed the feature/wallet_orchard branch from 296b743 to f139cdc Compare December 15, 2021 23:41
LarryRuane
LarryRuane commented Dec 15, 2021
View reviewed changes

@LarryRuane LarryRuane left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force-pushed to address review comments

Comment thread src/wallet/rpcwallet.cpp Outdated
Comment thread src/wallet/test/rpc_wallet_tests.cpp Outdated
@mdr0id mdr0id added safe-to-build Used to send PR to prod CI environment and removed safe-to-build Used to send PR to prod CI environment labels Dec 16, 2021
@nuttycom
nuttycom self-requested a review December 17, 2021 17:05
nuttycom
nuttycom approved these changes Dec 17, 2021
View reviewed changes

@nuttycom nuttycom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f139cdc: Re-reviewed https://github.com/zcash/zcash/compare/ee71462755d3c269ec0e3ac8bd097b8c30910f3b..LarryRuane:feature/wallet_orchard

@r3ld3v r3ld3v added S-committed Status: Planned work in a sprint and removed S-committed Status: Planned work in a sprint labels Dec 20, 2021
str4d
str4d approved these changes Dec 20, 2021
View reviewed changes

@str4d str4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f139cdc

@str4d
str4d merged commit 3acc685 into zcash:feature/wallet_unified_addresses Dec 20, 2021
@str4d str4d mentioned this pull request Dec 20, 2021
Closed
@str4d str4d mentioned this pull request Jan 14, 2022
Merged
@str4d str4d mentioned this pull request Feb 14, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ebfull ebfull Awaiting requested review from ebfull
3 more reviewers
@daira daira daira approved these changes
@nuttycom nuttycom nuttycom approved these changes
@str4d str4d str4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-committed Status: Planned work in a sprint safe-to-build Used to send PR to prod CI environment

Projects

None yet

Milestone

Core Sprint 2021-50

Development

Successfully merging this pull request may close these issues.

7 participants

@LarryRuane @str4d @nuttycom @daira @ebfull @mdr0id @r3ld3v