rpc: Disable Sprout address generation #5368

[LarryRuane]

Closes #5368.

[nuttycom]

One very minor change required.

[mdr0id]

Error for windows @LarryRuane :

libtool: warning: '-version-info/-version-number' is ignored for convenience libraries
  CC       randombytes/internal/librdrand_la-randombytes_internal_random.lo
libtool: warning: '-version-info/-version-number' is ignored for convenience libraries
  CCLD     libssse3.la
In file included from randombytes/internal/randombytes_internal_random.c:55:
In file included from ./include/sodium/private/common.h:248:
In file included from /workspace/source/depends/x86_64-w64-mingw32/native/lib/clang/13.0.0/include/intrin.h:12:
In file included from /usr/x86_64-w64-mingw32/include/intrin.h:41:
/usr/x86_64-w64-mingw32/include/psdk_inc/intrin-impl.h:1944:18: error: function cannot return function type 'int (unsigned int)'
unsigned __int64 _xgetbv(unsigned int);
                 ^
/workspace/source/depends/x86_64-w64-mingw32/native/lib/clang/13.0.0/include/xsaveintrin.h:35:42: note: expanded from macro '_xgetbv'
#define _xgetbv(A) __builtin_ia32_xgetbv((long long)(A))
                                         ^
In file included from randombytes/internal/randombytes_internal_random.c:55:
In file included from ./include/sodium/private/common.h:248:
In file included from /workspace/source/depends/x86_64-w64-mingw32/native/lib/clang/13.0.0/include/intrin.h:12:
In file included from /usr/x86_64-w64-mingw32/include/intrin.h:41:
/usr/x86_64-w64-mingw32/include/psdk_inc/intrin-impl.h:1947:18: error: function cannot return function type 'int (unsigned int)'
unsigned __int64 _xgetbv(unsigned int index)
                 ^
/workspace/source/depends/x86_64-w64-mingw32/native/lib/clang/13.0.0/include/xsaveintrin.h:35:42: note: expanded from macro '_xgetbv'
#define _xgetbv(A) __builtin_ia32_xgetbv((long long)(A))
                                         ^
libtool: warning: '-version-info/-version-number' is ignored for convenience libraries
  CCLD     libavx2.la
libtool: warning: '-version-info/-version-number' is ignored for convenience libraries
randombytes/internal/randombytes_internal_random.c:128:8: warning: unknown attribute 'thread' ignored [-Wunknown-attributes]
static TLS InternalRandom stream = {
       ^~~
randombytes/internal/randombytes_internal_random.c:98:26: note: expanded from macro 'TLS'
#  define TLS __declspec(thread)
                         ^~~~~~
<built-in>:346:38: note: expanded from here
#define __declspec(a) __attribute__((a))
                                     ^
1 warning and 2 errors generated.
make[4]: *** [Makefile:2307: randombytes/internal/librdrand_la-randombytes_internal_random.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory '/workspace/source/depends/work/build/x86_64-w64-mingw32/libsodium/1.0.18-40c4aa5332d/src/libsodium'
make[3]: *** [Makefile:3111: all-recursive] Error 1
make[3]: Leaving directory '/workspace/source/depends/work/build/x86_64-w64-mingw32/libsodium/1.0.18-40c4aa5332d/src/libsodium'
make[2]: Leaving directory '/workspace/source/depends/work/build/x86_64-w64-mingw32/libsodium/1.0.18-40c4aa5332d/src'
make[2]: *** [Makefile:400: all-recursive] Error 1
make[1]: *** [Makefile:515: all-recursive] Error 1
make[1]: Leaving directory '/workspace/source/depends/work/build/x86_64-w64-mingw32/libsodium/1.0.18-40c4aa5332d'
make: *** [funcs.mk:248: /workspace/source/depends/work/build/x86_64-w64-mingw32/libsodium/1.0.18-40c4aa5332d/./.stamp_built] Error 2
make: Leaving directory '/workspace/source/depends'

zcash-build-ipfs-qtcnt-zcash-lint-build-upload-pinata-n74-hlpv2__step-build__log.txt

[nuttycom]

That's a weird error, nothing in this PR affects the dependencies, and that's a failure in the libsodium build.

[LarryRuane]

Thanks for your review, @nuttycom, force-pushed to fix -1 error.

[nuttycom]

utACK

[defuse]

Changes requested from @daira and me.

[LarryRuane]

Force-pushed fixes for review comments, thanks.

[nuttycom]

re-utACK

[daira]

utACK

[defuse]

utACK