Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully-validate contents of UAs and UFVKs on parsing #5484

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Fully-validate contents of UAs and UFVKs on parsing #5484

merged 3 commits into from
Jan 19, 2022

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Jan 18, 2022

Closes #5466.

@str4d str4d added A-dependencies Area: Dependencies L-rust Involves Rust code. A-rust-ffi Area: The Rust FFI in the librustzcash library. NU5 Network upgrade: NU5-specific tasks labels Jan 18, 2022
@str4d str4d added this to the Core Sprint 2022-02 milestone Jan 18, 2022
@str4d str4d requested a review from nuttycom January 18, 2022 21:29
@str4d
rust: Add missing Orchard receiver check in UA parsing
f2e0a8d 
We didn't add it at the time because the necessary API did not exist in
the `orchard` crate. The API has since been added.
@str4d
rust: Add missing checks for shielded UFVK items
9b61806
@str4d
rust: Add missing checks for transparent UFVK items
714f141
nuttycom
nuttycom approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with @daira

@str4d str4d merged commit 6b335ec into zcash:feature/wallet_unified_addresses Jan 19, 2022
@str4d str4d deleted the 5466-ua-validation branch January 19, 2022 02:35
@str4d str4d mentioned this pull request Jan 19, 2022
Closed
@str4d str4d mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
A-dependencies Area: Dependencies A-rust-ffi Area: The Rust FFI in the librustzcash library. L-rust Involves Rust code. NU5 Network upgrade: NU5-specific tasks
Projects
None yet
Milestone
Core Sprint 2022-02
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom