Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIPs 32 and 316: add internal key derivation for Sapling, Orchard, and P2PKH #576

Merged
merged 13 commits into from
Jan 19, 2022

Conversation

daira
Copy link
Collaborator

@daira daira commented Dec 31, 2021

Closes #572

@daira daira added this to the Core Sprint 2021-50 milestone Dec 31, 2021
@daira daira force-pushed the internal-key-derivation branch 2 times, most recently from 328d849 to 293f563 Compare December 31, 2021 15:59
@daira daira changed the title ZIP 32: add internal key derivation for Sapling and Orchard ZIPs 32 and 316: add internal key derivation for Sapling, Orchard, and P2PKH Dec 31, 2021
@daira daira marked this pull request as ready for review December 31, 2021 23:21
@daira daira requested review from nuttycom and str4d December 31, 2021 23:21
@r3ld3v r3ld3v modified the milestones: Core Sprint 2021-50, 2021-52 Jan 3, 2022
@str4d str4d added the S-committed Status: Planned work in a sprint label Jan 3, 2022
zip-0032.rst Outdated Show resolved Hide resolved
zip-0316.rst Show resolved Hide resolved
@daira daira force-pushed the internal-key-derivation branch 3 times, most recently from 686b7e4 to 84bf1b6 Compare January 14, 2022 22:02
@daira daira force-pushed the internal-key-derivation branch 2 times, most recently from f8df2b8 to c47a3fd Compare January 18, 2022 19:10
@daira daira marked this pull request as ready for review January 18, 2022 19:16
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with a suggestion.

zip-0032.rst Outdated Show resolved Hide resolved
zip-0032.rst Outdated Show resolved Hide resolved
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…ing.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…m. This is stronger than

the former requirement that a UA/UVK MUST NOT contain only P2SH or P2PKH items, due to the
existence of Typecodes that are not currently defined.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…P 321.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…al address/FVK for every

external address/FVK.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira merged commit 43c8cae into zcash:main Jan 19, 2022
@daira daira deleted the internal-key-derivation branch January 19, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NU5 proposal S-committed Status: Planned work in a sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ZIP 316] Document change key derivation for UFVKs.
4 participants