Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching Sigma Generator creation #516

Merged
merged 4 commits into from Jul 15, 2019

Conversation

@levonpetrosyan93
Copy link
Contributor

commented Jul 14, 2019

A concern was brought up on the public verifiability of the randomness of g in the Sigma generator. While we aren't aware of how this can be exploited as there is no discrete log relationship between g and h, the team agreed that it was best practice to have the generation of g publicly verifiable.

This PR makes g as a hash of the base point of secp256k1 library.

@catchingknives catchingknives added this to the v0.13.8.2 milestone Jul 14, 2019
src/sigma/params.cpp Outdated Show resolved Hide resolved
src/sigma/params.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

LGTM

@reubenyap reubenyap merged commit 55b60db into master Jul 15, 2019
1 of 3 checks passed
1 of 3 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@levonpetrosyan93 levonpetrosyan93 deleted the sigma_patch branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.