Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dumpwallet in legacy/non-HD #527

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@riordant
Copy link
Contributor

commented Jul 18, 2019

The check in dumpwallet for version of CKeyMetadata in not sufficient - With legacy and non-HD wallets, this check will still pass, even if the key created is not HD. So also check for existence of the relevant metadata.

@catchingknives catchingknives added this to the v0.13.8.3 milestone Jul 18, 2019

@riordant riordant requested a review from levonpetrosyan93 Jul 19, 2019

@riordant riordant merged commit 8c0758d into master Jul 19, 2019

2 of 4 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@riordant riordant deleted the nonhd-fix branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.