Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with parsing legacy HD keypath #536

Merged
merged 4 commits into from Jul 26, 2019

Conversation

@riordant
Copy link
Contributor

commented Jul 23, 2019

Fixes issue where old keypath format does not parse correctly in importwallet. Also adds information on hardened components to CKeyMetadata

@riordant riordant added this to the v0.13.8.3 milestone Jul 23, 2019

@riordant riordant requested review from thebevrishot and a-bezrukov Jul 23, 2019

@reubenyap reubenyap added the bug label Jul 24, 2019

@reubenyap reubenyap added this to In progress in Zcoin Core via automation Jul 24, 2019

src/wallet/walletdb.h Outdated Show resolved Hide resolved

@riordant riordant changed the title Fix issue with parsing legacy hd keypath Fix issue with parsing legacy HD keypath Jul 25, 2019

@thebevrishot
Copy link
Member

left a comment

Thanks for updating. Have some type issue.

src/wallet/walletdb.h Outdated Show resolved Hide resolved
@levonpetrosyan93
Copy link
Collaborator

left a comment

LGTM

src/wallet/walletdb.h Outdated Show resolved Hide resolved
src/wallet/walletdb.h Outdated Show resolved Hide resolved

Zcoin Core automation moved this from In progress to Needs review Jul 26, 2019

@thebevrishot
Copy link
Member

left a comment

Thanks for fixing. LGTM

Zcoin Core automation moved this from Needs review to Reviewer approved Jul 26, 2019

@thebevrishot thebevrishot merged commit b4fcbfb into master Jul 26, 2019

1 of 3 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Zcoin Core automation moved this from Reviewer approved to Done Jul 26, 2019

@thebevrishot thebevrishot deleted the keypath-fix branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.