Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wrong transaction size estimation #568

Merged
merged 5 commits into from Aug 7, 2019

Conversation

@levonpetrosyan93
Copy link
Collaborator

commented Aug 2, 2019

Fixes #562

@reubenyap reubenyap added this to the v0.13.8.3 milestone Aug 2, 2019

@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Aug 2, 2019

@reubenyap reubenyap added the bug label Aug 2, 2019

@FreakyMaryk FreakyMaryk self-requested a review Aug 2, 2019

@FreakyMaryk
Copy link
Contributor

left a comment

Verified.

@ultimaweapon
Copy link
Member

left a comment

We need to revise logic due to there is 2 modes for it.

src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved

@reubenyap reubenyap modified the milestones: v0.13.8.3, v0.13.8.4 Aug 2, 2019

@FreakyMaryk FreakyMaryk self-requested a review Aug 2, 2019

src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved
src/qt/sigmacoincontroldialog.cpp Outdated Show resolved Hide resolved

Zcoin Core automation moved this from Needs review to Reviewer approved Aug 7, 2019

@ultimaweapon ultimaweapon merged commit e366201 into master Aug 7, 2019

1 of 3 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Zcoin Core automation moved this from Reviewer approved to Done Aug 7, 2019

@ultimaweapon ultimaweapon deleted the fix_txsize branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.