Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database counter for reminted change #576

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@riordant
Copy link
Contributor

commented Aug 3, 2019

PR intention

The internal counter that chooses the next mint to use for change is not being updated. As a result, following a sigma spend involving reminting, the subsequent transaction uses the same mint as as the one previous.

Code changes brief

  • Add UpdateCountDB() to CommitSigmaTransaction. This simply writes the current nCountLastUse to the DB. If it hasn't changed, it has no effect.

  • Increased verbosity of logging for mint count

@psolstice
Copy link
Contributor

left a comment

LGTM, works in my tests

@reubenyap reubenyap merged commit 39670ee into master Aug 3, 2019

2 of 4 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@reubenyap reubenyap deleted the mint-change-fix branch Aug 3, 2019

@catchingknives catchingknives added this to the v0.13.8.3 milestone Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.