Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed another znode-related deadlock #612

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@psolstice
Copy link
Contributor

commented Aug 14, 2019

PR intention

Fix deadlock in znode code

Code changes brief

Fixed this race condition:

2019-08-14 11:06:37 POTENTIAL DEADLOCK DETECTED
2019-08-14 11:06:37 Previous lock order was:
2019-08-14 11:06:37  (1) cs_mapZnodeBlocks  znode-payments.cpp:603
2019-08-14 11:06:37  cs_mapZnodePaymentVotes  znode-payments.cpp:603
2019-08-14 11:06:37  (2) cs  znodeman.h:316
2019-08-14 11:06:37 Current lock order is:
2019-08-14 11:06:37  (2) cs  znodeman.cpp:1576
2019-08-14 11:06:37  (1) cs_mapZnodeBlocks  znode.cpp:410

with removal of extra unneeded lock

@reubenyap reubenyap added this to the v0.13.8.4 milestone Aug 15, 2019

@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Aug 15, 2019

@reubenyap reubenyap added the bug label Aug 15, 2019

Zcoin Core automation moved this from Needs review to Reviewer approved Aug 15, 2019

@ultimaweapon ultimaweapon merged commit cb79ae6 into master Aug 15, 2019

2 of 4 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

Zcoin Core automation moved this from Reviewer approved to Done Aug 15, 2019

@ultimaweapon ultimaweapon deleted the znode-deadlock-fix2 branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.