Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with failing GetAddressGroupings with Private Spends #730

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Oct 9, 2019

Fixes #723

PR intention

GetAddressGroupings() in wallet/wallet.cpp is causing a segfault if the wallet contains Zerocoin or Sigma spends. The issue is it expects each input of the transaction it's looking at to be associated with an address, spend inputs are not.

Code changes brief

Avoid the code block that deals with inputs entirely by checking if the overall tx is a spend. This is sufficient as spends cannot have non-spend inputs.

Copy link
Member

thebevrishot left a comment

I think we could also prevent crashing because of reminting zerocoin to sigma too.

@riordant

This comment has been minimized.

Copy link
Contributor Author

riordant commented Oct 10, 2019

@thebevrishot good catch. Updated

Copy link
Member

thebevrishot left a comment

LGTM

@thebevrishot thebevrishot merged commit 8beeae2 into master Oct 10, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@ultimaweapon ultimaweapon deleted the addressgrouping-fix branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.