Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban zcoin nodes with version < 0.13.8.2 #742

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@psolstice
Copy link
Contributor

psolstice commented Oct 18, 2019

PR intention

Ban versions of zcoin client below 0.13.8.2

Code changes brief

Parse standard client version string in form of /Satosh:0.x.y.z/ and drop connection with every legacy node

@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Oct 20, 2019
@reubenyap reubenyap added this to the v0.13.8.5 milestone Oct 20, 2019
@qashban4 qashban4 requested review from levonpetrosyan93 and riordant Oct 20, 2019
Zcoin Core automation moved this from Needs review to Reviewer approved Oct 22, 2019
Copy link
Contributor

riordant left a comment

LGTM

@riordant riordant merged commit 7c1d88f into master Oct 22, 2019
5 checks passed
5 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Zcoin Core automation moved this from Reviewer approved to Done Oct 22, 2019
@riordant riordant deleted the ban-old-versions branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.