Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double mint fix #744

Merged
merged 6 commits into from Oct 23, 2019

Conversation

@levonpetrosyan93
Copy link
Contributor

levonpetrosyan93 commented Oct 20, 2019

Fix for #743

@levonpetrosyan93 levonpetrosyan93 requested review from psolstice and riordant Oct 20, 2019
Copy link
Contributor

psolstice left a comment

I think we need a unit test for it

@levonpetrosyan93

This comment has been minimized.

Copy link
Contributor Author

levonpetrosyan93 commented Oct 21, 2019

I think we need a unit test for it

Yes, Thank you, will add.

src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/sigma.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

riordant left a comment

LGTM

@reubenyap reubenyap merged commit b8411b8 into master Oct 23, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@levonpetrosyan93 levonpetrosyan93 deleted the double_mint_fix branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.