Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonic updates #772

Merged
merged 1 commit into from Nov 27, 2019
Merged

Mnemonic updates #772

merged 1 commit into from Nov 27, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Nov 25, 2019

  • add usemnemonic conf setting, on by default (as we have with usehd). this allows us to create non-mnemonic wallets and block key imports to mnemonic wallets
  • remove code that creates new master key for non-mnemonic wallets
Copy link
Contributor

levonpetrosyan93 left a comment

LGTM

@reubenyap reubenyap requested a review from a-bezrukov Nov 27, 2019
@riordant riordant merged commit 7651f5b into mnemonic Nov 27, 2019
5 checks passed
5 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@riordant riordant deleted the mnemonic-updates branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.