Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final mnemonic updates #774

Merged
merged 1 commit into from Nov 28, 2019
Merged

Final mnemonic updates #774

merged 1 commit into from Nov 28, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Nov 28, 2019

PR intention

Finalize the mnemonic PR

Code changes brief

Mnemonic window:

  • change welcome text and height
  • checkbox for mnemonic passphrase + small explainer text
  • disallow empty passphrase when checkbox set
  • Clear text boxes when toggling

Backend:

  • handle conf file parameter interaction
  • block importing a dumpfile or a private key for mnemonic wallet
  • Update RPC tests to disable mnemonic by default
Copy link
Collaborator

catchingknives left a comment

LGTM

Copy link
Contributor

levonpetrosyan93 left a comment

Please fix failing RPC. Remaining looks good.

@riordant riordant force-pushed the mnemonic_updates branch from 225a6a2 to 4dc715f Nov 28, 2019
@riordant riordant merged commit 61a85ca into mnemonic Nov 28, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@riordant riordant deleted the mnemonic_updates branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.