Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with old Zerocoin import #787

Merged
merged 1 commit into from Dec 17, 2019
Merged

Fix issue with old Zerocoin import #787

merged 1 commit into from Dec 17, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Dec 10, 2019

PR intention

Fixes an issue with importing Zerocoins from before the ECDSA key was introduced.

Code changes brief

On import, the string containing Zerocoin data is split into n elements. The last of these elements is a #, which is a delimiter for the next line. This extra element was not taken into account when attempting to import the ECDSA key and IsUsedForRemint boolean - old Zerocoins would try to import this values, leading to a bad access.

Copy link
Contributor

levonpetrosyan93 left a comment

LGTM

@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Dec 12, 2019
@reubenyap reubenyap added this to the 13.8.10 milestone Dec 12, 2019
@reubenyap reubenyap added the bug label Dec 12, 2019
@reubenyap reubenyap requested a review from psolstice Dec 17, 2019
Zcoin Core automation moved this from Needs review to Reviewer approved Dec 17, 2019
@reubenyap reubenyap merged commit a5b96ba into master Dec 17, 2019
5 checks passed
5 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Zcoin Core automation moved this from Reviewer approved to Done Dec 17, 2019
@reubenyap reubenyap deleted the old-zerocoin-fix branch Dec 17, 2019
@reubenyap

This comment has been minimized.

Copy link
Member

reubenyap commented Dec 17, 2019

Solves #760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zcoin Core
  
Done
4 participants
You can’t perform that action at this time.