Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt Sigma page updates #796

Merged
merged 1 commit into from Dec 17, 2019
Merged

Qt Sigma page updates #796

merged 1 commit into from Dec 17, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Dec 16, 2019

PR intention

Fixes #784
Fixes and updates for the Sigma page in Qt

Code changes brief

  • Update "Coin Control Features" layout when "amount to mint" or "Amount" changed at mint/spend tab respectively
  • Clear the "Coin Control Features" layout when switching between mint/spend tabs - but preserve the backend state so that the same selection is there when switching back
  • Ensure only correct outputs considered for selection - normal outputs for the mint tab and mint outputs for the spend tab
  • Also fixes an issue where entire page disappears if escape key pressed without an element focused.
@riordant riordant requested a review from levonpetrosyan93 Dec 16, 2019
Copy link
Contributor

levonpetrosyan93 left a comment

Looks good

@reubenyap reubenyap added this to the 13.8.10 milestone Dec 17, 2019
@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Dec 17, 2019
@reubenyap reubenyap requested a review from a-bezrukov Dec 17, 2019
Zcoin Core automation moved this from Needs review to Reviewer approved Dec 17, 2019
@a-bezrukov a-bezrukov merged commit 0cd3aec into master Dec 17, 2019
5 checks passed
5 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Zcoin Core automation moved this from Reviewer approved to Done Dec 17, 2019
@a-bezrukov a-bezrukov deleted the sigma_page branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zcoin Core
  
Done
4 participants
You can’t perform that action at this time.