Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban zcoin nodes with version < 0.13.8.8 #797

Merged
merged 2 commits into from Dec 23, 2019
Merged

Ban zcoin nodes with version < 0.13.8.8 #797

merged 2 commits into from Dec 23, 2019

Conversation

@justanwar
Copy link
Collaborator

justanwar commented Dec 17, 2019

PR intention

Ban versions of Zcoin client 0.13.8.5 and below

Code changes brief

"Parse standard client version string in form of /Satosh:0.x.y.z/ and drop connection with every legacy node" - As per #742

@@ -49,6 +49,6 @@ static const int SHORT_IDS_BLOCKS_VERSION = 90013;
static const int INVALID_CB_NO_BAN_VERSION = 90013;

//! minimum version of official client to connect to
static const int MIN_ZCOIN_CLIENT_VERSION = 130802; // 0.13.8.2
static const int MIN_ZCOIN_CLIENT_VERSION = 130805; // 0.13.8.5

This comment has been minimized.

Copy link
@psolstice

psolstice Dec 17, 2019

Contributor

I think we need to set it to the first version that use sigma padding (including private releases!).

This comment has been minimized.

Copy link
@justanwar

justanwar Dec 17, 2019

Author Collaborator

I'm trying to locate which private version sigma padding was released in, if that fails it looks like we have to go with v0.13.8.8

@riordant riordant added this to the 13.8.10 milestone Dec 17, 2019
@justanwar justanwar changed the title Ban zcoin nodes with version ≤ 0.13.8.5 Ban zcoin nodes with version < 0.13.8.8 Dec 23, 2019
@reubenyap reubenyap merged commit 0c85825 into master Dec 23, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@reubenyap reubenyap deleted the ban-130805 branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.