Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude locked coins from Available to mint amount #799

Merged
merged 5 commits into from Dec 20, 2019
Merged

Conversation

@levonpetrosyan93
Copy link
Contributor

levonpetrosyan93 commented Dec 17, 2019

Implementation of #762

@riordant riordant self-requested a review Dec 18, 2019
Copy link
Contributor

riordant left a comment

@levonpetrosyan93 how is this meant to work? If I lock a coin in Coin Control Features, the amount in Available amount to mint does not change (even after clicking "OK" in the Coin Control Features box).

Theres also another bug: locked coins appear in both Mint and Spend coin control windows, regardless of the output type. eg. if you lock a mint output in the Spend window, and switch to the Mint window, the mint shows there, when it should not.

@levonpetrosyan93

This comment has been minimized.

Copy link
Contributor Author

levonpetrosyan93 commented Dec 18, 2019

Thank you Tadhg, will fix first, about sencond, I think it is not due to my changes, but will try to fix it also.

@reubenyap reubenyap requested a review from a-bezrukov Dec 20, 2019
@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Dec 20, 2019
@reubenyap reubenyap added this to the 13.8.10 milestone Dec 20, 2019
@levonpetrosyan93 levonpetrosyan93 requested a review from riordant Dec 20, 2019
Copy link
Contributor

riordant left a comment

Issues fixed, LGTM.

Zcoin Core automation moved this from Needs review to Reviewer approved Dec 20, 2019
@riordant riordant merged commit b63c980 into master Dec 20, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Zcoin Core automation moved this from Reviewer approved to Done Dec 20, 2019
@riordant riordant deleted the exclude_locked branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zcoin Core
  
Done
4 participants
You can’t perform that action at this time.