Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB deadlock in NewKeyPool #802

Merged
merged 2 commits into from Dec 27, 2019
Merged

Fix DB deadlock in NewKeyPool #802

merged 2 commits into from Dec 27, 2019

Conversation

@riordant
Copy link
Contributor

riordant commented Dec 20, 2019

PR intention

Fixes an issue with a DB deadlock when calling NewKeyPool() during wallet load. This occurs during the upgrade of unencrypted wallets to Sigma.
Also correctly sets the CHDChain version to VERSION_WITH_BIP44 rather than the now default VERSION_WITH_BIP39.

@riordant riordant changed the title Fix db deadlock Fix DB deadlock in NewKeyPool Dec 20, 2019
@riordant riordant requested a review from ultimaweapon Dec 20, 2019
@reubenyap reubenyap added this to Needs review in Zcoin Core via automation Dec 23, 2019
@reubenyap reubenyap added this to the 13.8.10 milestone Dec 23, 2019
@reubenyap reubenyap requested a review from a-bezrukov Dec 23, 2019
Andrey
Zcoin Core automation moved this from Needs review to Reviewer approved Dec 27, 2019
@ultimaweapon ultimaweapon merged commit 99abf87 into master Dec 27, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Zcoin Core automation moved this from Reviewer approved to Done Dec 27, 2019
@ultimaweapon ultimaweapon deleted the bip44-fix branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Zcoin Core
  
Done
4 participants
You can’t perform that action at this time.