Support for Ruby 2.0 #39

Closed
mechiland opened this Issue Mar 26, 2013 · 20 comments

Comments

Projects
None yet
7 participants
@mechiland

Now ruby 2.0 is ready for production. I have tested that only 0.7.7 support ruby 2.0, all the later versions > 0.7.7 doesn't support Ruby 2.0.

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Mar 26, 2013

Owner

This is good to know! Let me know if you find time to come up with a patch to fix the issues. We applied several patches since Version 0.7.7. If that works on Ruby 2.0.0 that is great! There will not be a lot that we have to fix.

Owner

zdavatz commented Mar 26, 2013

This is good to know! Let me know if you find time to come up with a patch to fix the issues. We applied several patches since Version 0.7.7. If that works on Ruby 2.0.0 that is great! There will not be a lot that we have to fix.

@zdavatz zdavatz closed this Apr 3, 2013

kachick added a commit to kachick/spreadsheet that referenced this issue Apr 3, 2013

@orangethunder

This comment has been minimized.

Show comment Hide comment
@orangethunder

orangethunder May 15, 2013

I just want to add, before anyone else wastes time downgrading to 0.7.7 for Ruby 2.0 compatibility, that it also generated corrupt excel data for me.

I just want to add, before anyone else wastes time downgrading to 0.7.7 for Ruby 2.0 compatibility, that it also generated corrupt excel data for me.

@apeiros

This comment has been minimized.

Show comment Hide comment
@apeiros

apeiros Jun 29, 2013

It would have been nice to leave this open. I (and most people) generally don't search closed issues for issues which are still open.

apeiros commented Jun 29, 2013

It would have been nice to leave this open. I (and most people) generally don't search closed issues for issues which are still open.

@pomartel

This comment has been minimized.

Show comment Hide comment
@pomartel

pomartel Jun 30, 2013

I switched from Spreadsheet to https://github.com/cxn03651/writeexcel which has a similar syntax and works with Ruby 2.0 and so far it's been working great.

I switched from Spreadsheet to https://github.com/cxn03651/writeexcel which has a similar syntax and works with Ruby 2.0 and so far it's been working great.

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 2, 2013

Owner

As soon as someone comes with a patch I will reopen.

Owner

zdavatz commented Jul 2, 2013

As soon as someone comes with a patch I will reopen.

@krainboltgreene

This comment has been minimized.

Show comment Hide comment
@krainboltgreene

krainboltgreene Jul 20, 2013

You're hiding the visibility of this thing, who will know to make a patch?

You're hiding the visibility of this thing, who will know to make a patch?

@apeiros

This comment has been minimized.

Show comment Hide comment
@apeiros

apeiros Jul 20, 2013

You know, the point of issues is to have those open which still are an issue. and this is. It's not the point of issues to be "briefly open when there's a patch around". This is silly beyond reason.

apeiros commented Jul 20, 2013

You know, the point of issues is to have those open which still are an issue. and this is. It's not the point of issues to be "briefly open when there's a patch around". This is silly beyond reason.

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 22, 2013

Owner

Well, this is not an issue this is a feature request. And obviously people are reading this thread as well. Ruby 2.0.0 Support will come. But if you are impatient you will have to come up with patches. If you want a free lunch then you will have to wait until it is provided.

Owner

zdavatz commented Jul 22, 2013

Well, this is not an issue this is a feature request. And obviously people are reading this thread as well. Ruby 2.0.0 Support will come. But if you are impatient you will have to come up with patches. If you want a free lunch then you will have to wait until it is provided.

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 23, 2013

Owner

Free lunch is now in the making. Please be patient.

Owner

zdavatz commented Jul 23, 2013

Free lunch is now in the making. Please be patient.

@krainboltgreene

This comment has been minimized.

Show comment Hide comment
@krainboltgreene

krainboltgreene Jul 23, 2013

Dude, you kept the issue closed, no one can see that something needs to be contributed.

You can't then be passive aggressive about having to do the thing no one is contributing.

Dude, you kept the issue closed, no one can see that something needs to be contributed.

You can't then be passive aggressive about having to do the thing no one is contributing.

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 23, 2013

Owner

@krainboltgreene Obviously you are seeing and reading daily ;).

Owner

zdavatz commented Jul 23, 2013

@krainboltgreene Obviously you are seeing and reading daily ;).

@apeiros

This comment has been minimized.

Show comment Hide comment
@apeiros

apeiros Jul 23, 2013

@zdavatz the magic of getting emails on new comments :-p
Don't get me wrong, I very much appreciate your work on spreadsheet. But I strongly disagree with your rather unique reasoning of what is an issue and what not. Following your logic, every bug is really a feature request. The feature to "please make X work under condition Y" (because X exhibits broken behavior under condition Y - and here X = spreadsheet and Y = running under ruby 2.0).

apeiros commented Jul 23, 2013

@zdavatz the magic of getting emails on new comments :-p
Don't get me wrong, I very much appreciate your work on spreadsheet. But I strongly disagree with your rather unique reasoning of what is an issue and what not. Following your logic, every bug is really a feature request. The feature to "please make X work under condition Y" (because X exhibits broken behavior under condition Y - and here X = spreadsheet and Y = running under ruby 2.0).

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 23, 2013

Owner

@apeiros "Following your logic, every bug is really a feature request." Yes, that is true. I think that is a very good quote! Because in the end often bugs end up being new features.

But getting ready for Ruby 2.0.0 is not really a bug. It is also not an issue.

Owner

zdavatz commented Jul 23, 2013

@apeiros "Following your logic, every bug is really a feature request." Yes, that is true. I think that is a very good quote! Because in the end often bugs end up being new features.

But getting ready for Ruby 2.0.0 is not really a bug. It is also not an issue.

@apeiros

This comment has been minimized.

Show comment Hide comment
@apeiros

apeiros Jul 23, 2013

@zdavatz "Because in the end often bugs end up being new features." - then it was not really a bug, or not only a bug.

Software has a defined output for a defined input. If the actual output deviates from expected output, it is a bug. This is the case here. The cause is that underlying software changed. This fact however is irrelevant to the fact that the result is a bug.

And spreadsheet producing invalid output is both a bug and an issue (while not every issue is a bug, I'd say every bug is an issue).

apeiros commented Jul 23, 2013

@zdavatz "Because in the end often bugs end up being new features." - then it was not really a bug, or not only a bug.

Software has a defined output for a defined input. If the actual output deviates from expected output, it is a bug. This is the case here. The cause is that underlying software changed. This fact however is irrelevant to the fact that the result is a bug.

And spreadsheet producing invalid output is both a bug and an issue (while not every issue is a bug, I'd say every bug is an issue).

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 24, 2013

Owner

@apeiros thanks! I think you should write a book about this and publish it!

Owner

zdavatz commented Jul 24, 2013

@apeiros thanks! I think you should write a book about this and publish it!

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 24, 2013

Owner

Ok guys: spreadsheet-0.8.7 is here and this should support Ruby 2.0.0. Please open an issue if you find a bug.

Owner

zdavatz commented Jul 24, 2013

Ok guys: spreadsheet-0.8.7 is here and this should support Ruby 2.0.0. Please open an issue if you find a bug.

@canoeberry

This comment has been minimized.

Show comment Hide comment
@canoeberry

canoeberry Jul 16, 2015

Hate to ask, but if this runs in Ruby 2.0, who does the main page say 1.9.3?

Hate to ask, but if this runs in Ruby 2.0, who does the main page say 1.9.3?

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 16, 2015

Owner

Link please.

Owner

zdavatz commented Jul 16, 2015

Link please.

@canoeberry

This comment has been minimized.

Show comment Hide comment
@canoeberry

canoeberry Jul 16, 2015

Whoa - it was in the main readme. But now it's fixed. So either I hallucinated it or you fixed it. Sorry for the trouble!

Whoa - it was in the main readme. But now it's fixed. So either I hallucinated it or you fixed it. Sorry for the trouble!

@zdavatz

This comment has been minimized.

Show comment Hide comment
@zdavatz

zdavatz Jul 17, 2015

Owner

I fixed it. Thanks for the hint!

Owner

zdavatz commented Jul 17, 2015

I fixed it. Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment