Sql server #70

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
4 participants

btrepp commented Nov 1, 2012

Adds SQLServer support based of ouranos sql_server branch

This branch passes all tests. Though makes some sweeping (perhaps bad) assumptions. SQLServer does not allow NULL to be passed into the IDENTITY column. To get around this I have made instances of where the identity column is NULL ommit inserting the ID by removing it from the sql string.

This is making the assumption that the ID is the first column. It will probably cause issues if it is not the first column. But hey it passes all tests :)

Owner

zdennis commented Dec 14, 2012

@ouranos / @btrepp, I want to merge this in, but I don't currently run SQLServer. What's the easiest way for a non-SQLServer person like me to get access to and quickly up and running with SQLServer for testin this out?

btrepp commented Dec 14, 2012

I think there's a free version

SQL server express.

http://www.microsoft.com/en-au/download/details.aspx?id=29062

Though you will probably need windows at some point :)
On Dec 14, 2012 10:58 PM, "Zach Dennis" notifications@github.com wrote:

@ouranos https://github.com/ouranos / @btrepphttps://github.com/btrepp,
I want to merge this in, but I don't currently run SQLServer. What's the
easiest way for a non-SQLServer person like me to get access to and quickly
up and running with SQLServer for testin this out?


Reply to this email directly or view it on GitHubhttps://github.com/zdennis/activerecord-import/pull/70#issuecomment-11378900.

Owner

zdennis commented Dec 14, 2012

Thanks @btrepp, I've got a few Windows VM handy, so knowing that SQL Server Express is a thing is just what I needed! I'll see if I can get that set up this weekend.

ouranos commented Jan 3, 2013

@zdennis Sorry was in holidays. Yes SQL Server Express is the way to go.
Let me know how you go.

Collaborator

jkowens commented Oct 31, 2016

Thanks for your work. I'm closing this PR since this feature is continued on by #201.

@jkowens jkowens closed this Oct 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment