Permalink
Browse files

Fixed VML case of Series rgba color and tooltip border Closes #284

  • Loading branch information...
1 parent 8ed2ee0 commit 4ee9438a8407505e9ed507328c0cecd924196607 @eolsson eolsson committed Aug 12, 2011
Showing with 15 additions and 1 deletion.
  1. +4 −0 js/highcharts.src.js
  2. +4 −0 js/parts/VmlRenderer.js
  3. +7 −1 test/unit/RendererTest.js
View
@@ -3660,6 +3660,10 @@ VMLRenderer.prototype = merge(SVGRenderer.prototype, { // inherit SVGRenderer
} else {
+ var strokeNodes = elem.getElementsByTagName(prop);
+ if (strokeNodes.length) {
+ strokeNodes[0].opacity = 1;
+ }
return color;
}
View
@@ -769,6 +769,10 @@ VMLRenderer.prototype = merge(SVGRenderer.prototype, { // inherit SVGRenderer
} else {
+ var strokeNodes = elem.getElementsByTagName(prop);
+ if (strokeNodes.length) {
+ strokeNodes[0].opacity = 1;
+ }
return color;
}
@@ -62,6 +62,12 @@ RendererTest.prototype.testTransparancy = function () {
stroke: '#aabbcc'
});
- // Make sure there is no stray opacity
+ // Make sure there is no stray opacity (this is SVG case)
assertFalse('There is a stray opacity value', rect.element.hasAttribute('stroke-opacity'));
+
+ // Make sure there is no stray opacity (this is VML case)
+ var strokeElement = rect.element.getElementsByTagName('stroke')[0];
+ if (strokeElement) {
+ assertEquals('There is a stray opacity value', 1, strokeElement.opacity);
+ }
}

0 comments on commit 4ee9438

Please sign in to comment.