Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CraftingRecipes: Refactor using RecipeChoice #37

Closed
prokopyl opened this issue Nov 12, 2020 · 0 comments · Fixed by #65
Closed

CraftingRecipes: Refactor using RecipeChoice #37

prokopyl opened this issue Nov 12, 2020 · 0 comments · Fixed by #65
Labels
M ⋅ Outdated Bukkit API Miscelaneous – Tracks removal of deprecated/outdated/useless code due to a newer Bukkit API
Milestone
v0.1

Comments

@prokopyl
Copy link
Member

All overrides that use MaterialData should probably be removed, as it is now deprecated.

Overrides accepting RecipeChoices should probably be used instead, which will also allow for custom item testing logic.
@prokopyl prokopyl added the M ⋅ Outdated Bukkit API Miscelaneous – Tracks removal of deprecated/outdated/useless code due to a newer Bukkit API label Nov 12, 2020
@prokopyl prokopyl added this to the v0.1 milestone Nov 12, 2020
@prokopyl prokopyl mentioned this issue Dec 9, 2020
Merged
@AmauryCarrade AmauryCarrade linked a pull request Dec 10, 2020 that will close this issue
Update CraftingRecipes to use NamespacedKey, and RecipeChoice instead of MaterialData #65
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M ⋅ Outdated Bukkit API Miscelaneous – Tracks removal of deprecated/outdated/useless code due to a newer Bukkit API
Projects
None yet
Milestone
v0.1
1 participant
@prokopyl