Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Proposal: Move doc/install.sh to another dir #45

Closed
pschmitt opened this issue Nov 11, 2021 · 1 comment
Closed

💡 Proposal: Move doc/install.sh to another dir #45

pschmitt opened this issue Nov 11, 2021 · 1 comment
Labels
maintenance Task to maintain project in a working state
Milestone
v4.0.0

Comments

@pschmitt
Copy link
Member

pschmitt commented Nov 11, 2021 •
edited
Loading

While working on #43 I couldn't help but notice that the installer script is stored under doc/.

IMHO the doc/ dir should only - as the name implies - store documentation and not arbitrary scripts.

I'd like to move it to installer/install.sh or scripts/install/install.sh.
This shouldn't have many implications besides that the curl install instructions need to be updated once (and if) this is done.

Related: #55
@pschmitt pschmitt added this to the zinit 4.0 milestone Nov 11, 2021
@pschmitt pschmitt added maintenance Task to maintain project in a working state 🏛 proposal labels Nov 11, 2021
@pschmitt pschmitt mentioned this issue Nov 14, 2021
Closed
4 tasks
@pschmitt pschmitt changed the title 💡 Proposal: Move doc/install.sh to a another dir 💡 Proposal: Move doc/install.sh to another dir Nov 15, 2021
@pschmitt pschmitt mentioned this issue Nov 17, 2021
Merged
6 tasks
@pschmitt
Copy link
Member Author

Implemented in #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Task to maintain project in a working state
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@pschmitt