Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add system searching for WebP #2608

Closed
Hex4dec opened this issue Jun 27, 2024 · 6 comments
Closed

[Feature] Add system searching for WebP #2608

Hex4dec opened this issue Jun 27, 2024 · 6 comments

Comments

@Hex4dec
Copy link

Hex4dec commented Jun 27, 2024

GZDoom version

CMakeLists.txt from g14.12.2

Which game are you running with GZDoom?

None

What Operating System are you using?

None

If Other OS, please describe

No response

Relevant hardware info

No response

Is your feature request related to a problem? Please describe.

There is no FORCE_INTERNAL_WEBP or for that matter, any system searching for the webp library.

Describe the solution you'd like

It would be nice if there would be a FORCE_INTERNAL_WEBP flag I could disable so I can use the system WebP library. I trust my package manager more than GZDoom.

Describe alternatives you've considered

No response

Add any other context or screenshots about the feature request here.

No response

@RicardoLuis0
Copy link
Collaborator

pretty sure you can revert these 3 commits to make it use the system libraries:
26fe8f0
648b1a1
140ad88

@RicardoLuis0
Copy link
Collaborator

(i'll also add it to cmake, but will take a bit of testing/time)

@Hex4dec
Copy link
Author

Hex4dec commented Jun 27, 2024

The reason for it being internal-only (or even internal-optional) is quite ridiculous. Package managers are supposed to do their job and you shouldn't worry about it. If vcpkg's package "breaks overnight", you shouldn't touch it and instead yell at vcpkg's maintainers to fix it.

Anyway, thank you.

@RicardoLuis0
Copy link
Collaborator

the reason for using vcpkg was to simplify package management on windows, since vcpkg broke, vcpkg was removed and the library was embedded

@coelckers
Copy link
Member

Note: If you revert those 3 commits you void your warranty.

Of course we could change it, but why should we make things harder for us by haviing to deal with third party induced problems?

@coelckers coelckers closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
@Hex4dec
Copy link
Author

Hex4dec commented Jun 28, 2024

Like it isn't already voided by the GPL, ha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants