feat(language server): add csharp-ls as a new option#77
Open
rbstp wants to merge 1 commit into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @rbstp on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds csharp-ls as a third language server option alongside OmniSharp and Roslyn. csharp-ls is an F#-based C# language server distributed as a
dotnet toolNuGet package; it is unrelated to the deprecatedSofusA/csharp-language-serverwrapper referenced by #11 and #57. The naming overlap is unfortunate: the upstream project markets itself ascsharp-lsprecisely to reduce that confusion.The use case is different from Roslyn. csharp-ls is a leaner alternative: cold start is faster, memory footprint is lower, and it stays responsive on small projects or quick edits where spinning up a full Roslyn workspace is overkill. Roslyn remains the right choice for the deepest Microsoft tooling; csharp-ls is for the case when you want something snappy.
To use it:
{ "languages": { "CSharp": { "language_servers": ["csharp-ls", "!omnisharp", "!roslyn"] } } }It partially addresses #62, it is running better on my own M3 mac for smaller projects.