LSP client not initialized when JDTLS is in the PATH

[tartarughina]

What happened?

When jdtls or jdtls.bat are available in the $PATH the following error is thrown

Java extension 6.6.0: Lsp client is not initialized yet

What did you expect to happen?

I expect that the extension used the provided JDTLS available in the $PATH

Environment

Zed: v0.211.2 (Zed Preview)
OS: macOS 15.7.1
Memory: 16 GiB
Architecture: x86_64

[tartarughina]

In java.rs at line 69 (nice), the field integrations is checked.
If none the fields are getting populated

if self.integrations.is_none() {
    let lsp = LspWrapper::new(worktree.root_path());
    let debugger = Debugger::new(lsp.clone());

    self.integrations = Some((lsp, debugger));
}

Such check is done when the function language_server_binary_path is called.
language_server_binary_path is only called when no jdtls is provided in the PATH.

Checking if jdtls is available in the PATH is done in java.rs at line 279

if let Some(launcher) = get_jdtls_launcher_from_path(worktree) {
    // if the user has `jdtls(.bat)` on their PATH, we use that
    args.push(launcher);
    if let Some(lombok_jvm_arg) = lombok_jvm_arg {
        args.push(format!("--jvm-arg={lombok_jvm_arg}"));
    }
} else {
    // otherwise we launch ourselves
    args.extend(build_jdtls_launch_args(
        &self.language_server_binary_path(language_server_id, worktree)?,
        &configuration,
        worktree,
        lombok_jvm_arg.into_iter().collect(),
    )?);
}

[ehsanghorbani190]

@tartarughina
Hello there! I'm wondering if this is published to the main version, because I still has this problem.
Also after this bug, the workaround for me was to pass the binary path in the settings.json. But it doesn't enable lombok with these settings. Have you encountered this? Is there a fix?

[tartarughina]

Hey there @ehsanghorbani190, the release has yet to be merged in the zed's extensions marketplace.

If you want to try out the new release you can clone this repo and install it by choosing the option in Zed 'install dev extension' and choosing the repo you just cloned.

Setting the binary from settings will override completely the extension, hence the reason why you lose Lombok. The initialization options you have a couple of lines below are not provided to the executed language server.

Let me know if 6.7.0 fixes the issue once either released or locally installed

[ehsanghorbani190]

@tartarughina
Thanks for the instructions! I've successfully installed the new version, and I can confirm that the new version fixes the issue. Great job!
Also, I didn't know the point you said about the initialization options, I think it's worth to note it in the docs.

[tartarughina]

Glad to hear it is fixed.

I'll add for sure in the doc the binary override point before the next release.