Skip to content

Conversation

@valentinegb
Copy link
Collaborator

Closes #24.

@valentinegb valentinegb added bug Something isn't working language-server Related to the language server. labels Dec 4, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 4, 2024
@valentinegb
Copy link
Collaborator Author

@nulliver, can you please test this?

@nulliver
Copy link

nulliver commented Dec 4, 2024

@valentinegb,

I just tested and it worked!

The server was started with the specified SDK in the home setting:

{
  "lsp": {
    "jdtls": {
      "initialization_options": {
        "settings": {
          "java": {
            "home": "/Users/username/.sdkman/candidates/java/21.0.5-tem"
          }
        }
      }
    }
  }
}

And when I compile/run a standalone file using a simple task (javac MyFile.java), it compiles using the $JAVA_HOME defined in my system.

It's working as expected! 💯

Thank you! =)

@valentinegb valentinegb merged commit 886456d into main Dec 4, 2024
1 check passed
@valentinegb valentinegb deleted the handle-java-home branch December 4, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla-signed language-server Related to the language server.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Java home setting does not change the JDK used to start the server

3 participants