Skip to content

Conversation

@kubkon
Copy link
Contributor

@kubkon kubkon commented Sep 15, 2025

⚠️ Don't merge until Zed 0.205.x is on stable ⚠️

See zed-industries/zed#37811

This PR bumps the zed extension API to the latest version, which makes std::env::current_dir() work correctly in WASI with Windows DOS paths.

@cla-bot cla-bot bot added the cla-signed label Sep 15, 2025
@maxbrunsfeld maxbrunsfeld changed the title Bump extension API for enhanced Windows support chore: Bump extension API for enhanced Windows support Sep 26, 2025
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Sep 26, 2025

@vitallium We typically squash merge, so I don't think the commit messages matter once a PR is merged. I attempted to change the PR title to the style with the category first. I think if we're wanting to have a certain format to the git commits on main, we'll need to adjust the style check to check the PR title, not the commits. Am I missing something there?

@maxbrunsfeld maxbrunsfeld merged commit 848ee46 into main Sep 26, 2025
3 of 4 checks passed
@maxbrunsfeld maxbrunsfeld deleted the extension-api-0.7.0 branch September 26, 2025 19:23
@vitallium
Copy link
Collaborator

@vitallium We typically squash merge, so I don't think the commit messages matter once a PR is merged. I attempted to change the PR title to the style with the category first. I think if we're wanting to have a certain format to the git commits on main, we'll need to adjust the style check to check the PR title, not the commits. Am I missing something there?

@maxbrunsfeld Probably. It could be that I misconfigured something. The idea is to have the same format for commits and PRs as in the main repo (Zed), but with a small tweak to allow commits in conventional style with lowercase sentences. I will have a look at the configuration. Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants