New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elixir LS failing to download #6179
Comments
|
Before I configured things in Zed I looked at the homebrew formula to make sure I was matching what it was doing. It makes sure the language server is compiled and that a symlink named Not sure where elixir-ls.zip came into play, are more recent versions of the beta trying to download the elixir language server automatically without me having to install it globally? That would be nice, that's what vscode does and it would be a welcome improvement. I'm excited that elixir-ls support is in progress though! It's the only thing standing between me and using Zed as my main editor :) Thanks for ya'lls efforts! |
|
For the Zed folks: #6178 looks like a duplicate |
|
As a hacky short-term fix I was able to get this working I think. I ended up creating a symlink in So to summarize:
If anyone's installed elixir-ls a different way the same solution should work (I think), you just need to find where your elixir-ls release is so you can symlink to the language_server.sh file it contains. I only tested jump to definition, find references, and that compile errors showed up in the file. I haven't actually done any significant coding yet so I can't say if surprises will crop up or not. Also confirmed I can view the elixir language server log output via the "open language server logs" command. Hopefully this helps people get unblocked until the bug can be fixed! Excited to try out Zed full-time :) |
Feeling the same as you. I wanted to replace once in for all VSCode by Zed, but not having Still, it's great to see that Elixir is talked on Zed docs, and hopefully it will be the best solution for Elixir development. I sometimes feel that VSCode is not 100% there. |
Unfortunately, this solution didn't worked for me. I've followed the steps you provided, but it didn't worked. @mattbaker I saw that you are on the Elixir Slack, if you can give me some sync assistance there I would be very much appreciated 🙂 |
|
I assume that the issue is caused by the recent change in the Release assets of ElixirLS on GitHub. https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.15.0 v0.15.0 is missing the asset In addition they changed the implementation to use IMO zed should consider to start the |
|
Thank you gents @ Zed for taking a look at this. I'm also waiting for this to land before giving Zed two weeks of solid attention. I love your mission and I am keen to use Zed instead of VSCode. |
|
For what it’s worth elixir-ls has been working in Zed perfectly with the workaround so far. I know @nbernardes wasn’t able to get it going (we’re not sure why) but I’d encourage you make an attempt if it means you get to start testing Zed a little sooner. Totally understand wanting to wait for a fix though, but I was impatient :) |
|
❤️ thanks @mattbaker, I just tried it and it works for me too, I've been without elixir-ls for 2 days and its been driving me crazy |
|
Confirming that the workaround provided by @mattbaker is working for me. Thanks dude 🙇 |
|
I've got the same issue with the elixir-ls not working, unfortunately the fix isn't working for me either 😢 |
|
Just confirming that the workaround provided by @mattbaker is working for me. thank you 🙏🏻
|
|
The fix worked for me after removing Zed from my system and installing the latest beta from the website. Adding "lsp": {
"Elixir": {}
}to |
|
I finally managed to get it working - had to completely remove Zed and the Zed directory in Thanks @zimt28, @jvelez1 and @mattbaker 😺 |
@benvp And |
|
Oh, I misread that. Sorry! |
|
Side note: The reason why the workaround might not work for some of us is that currently elixir-ls is broken with OTP 26 - the server does not start at all. It should be fixed when OTP 26.0.2 is released (If I understood the discussion correctly) |
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa Closes https://linear.app/zed-industries/issue/Z-665/add-a-mechanism-for-detecting-and-fixing-broken-language-server Fixes https://github.com/zed-industries/community/issues/1671 Fixes https://github.com/zed-industries/community/issues/1691 Fixes https://github.com/zed-industries/community/issues/1524 Fixes https://github.com/zed-industries/community/issues/1352 Fixes https://github.com/zed-industries/community/issues/1109 Fixes https://github.com/zed-industries/community/issues/996 Fixes https://github.com/zed-industries/community/issues/782 Things this PR does: - Updates our elixir-ls fetching to use new release name format - Detect when a server fails to launch - If the adapter claims to be reinstallable, get a test binary - If the test binary fails to launch or returns a failure error code - Clear container dir and reinstall - Detect/fix broken Node Things it does not do: - Restart server on failure, I have most of the stuff for this already so it should be a fast follow up - Detect/fix broken Copilot Node and Copilot shouldn't be too bad, they are handled via different mechanisms. Originally I put effort into detecting failure of the server during normal operation post launch, but that's not really needed. If the server gets borked while running then we'll catch that on next startup. Realizing that allowed for pruning a bunch of the work I did and made the overall system a lot nicer Copilot is nominally a language server but does not have an adapter and does not run through the same mechanism in the project. We're going to have an issue with multiple language server instances in different projects once we add a "Reinstall Language Server" action, which is why it's not in this PR. Each project has its own list of server instances and is currently vaguely responsible for managing the installations which means they can step on each others toes. This should change, probably Release Notes: - Added a mechanism to detect and reinstall broken language servers ([#1691](https://github.com/zed-industries/community/issues/1691)) ([#1524](https://github.com/zed-industries/community/issues/1524)) ([#1352](https://github.com/zed-industries/community/issues/1352)) ([#1109](https://github.com/zed-industries/community/issues/1109)) ([#996](https://github.com/zed-industries/community/issues/996)) ([#782](https://github.com/zed-industries/community/issues/782)).
|
After updating OTP 26.0.2 and delete the zed from my system I still can not use Elixir-ls formatter and autocompletion I use asdf |
|
@shahryarjb That's because a new version of elixir-ls (0.15.1) that fixes OTP 26 coop has not been published yet. Zed still downloads version 0.15.0 as of now. |
|
Want to confirm without doing any "hacks" or anything like that, my ElixirLS is now working fine and I can cmd+click into modules. Thanks! |
Confirmed for me as well with Zed 0.92.4 |
|
Elixir-ls 15.1 has been released, Zed has got it, and now language server works with Elixir 1.15.0 OTP 26.0.2. 🥳 |
|
It seems like bugy, because if something crashed like there is no macro or sth you should delete the build and deps to compile again!! |
Check for existing issues
Describe the bug / provide steps to reproduce it
When opening any project on Zed, I always get this error
elixir-lsworks in VSCode, and I'm usingelixiranderlangviaasdfEnvironment
Zed: v0.90.2 (stable)
OS: macOS 13.4.0
Memory: 32 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your
~/Library/Logs/Zed/Zed.logfile to this issue.If you only need the most recent lines, you can run the
zed: open logcommand palette action to see the last 1000.The text was updated successfully, but these errors were encountered: