-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSDoc syntax highlighting support #7826
Conversation
Wow, Thank you
|
I could definitely implement that. But I would create another PR for this feature, because I think those are two different features, especially since the syntax highlighting for regex could be beneficial for multiple languages and not only JS and TS. |
Yep. I'm in favor of implementing it in other PRs. and I think maybe could also help (also in another PR) to implement comment highlighting: zed-industries/extensions#523
tree-sitter: https://github.com/stsewd/tree-sitter-comment Two different scm to reference:
Thank you~ |
@SomeoneToIgnore @maxbrunsfeld @JosephTLyons If there is an interest in implementing something like that with the use of tree-sitter, I would be happy to help. |
Are there any issues with this PR now? Can it be merged now? |
@rpfaeffle similar to the other one, it seems worth merging this as it improves javascript (which I think will remain "in-core" for a while). Would you mind rebasing on main when you get some time? |
@ConradIrwin I did a rebase of the PR. Should be good to merge. |
Thanks! |
This PR improves JSDoc injection for syntax highlighting. Now we are only injecting JSDoc in block comments. The regex was mostly adapted from nvim-treesitter's implementation (lua) to a rust regex. https://github.com/nvim-treesitter/nvim-treesitter/blob/eb93c3b2fbe9ca55d70e9297d5c037880b997559/queries/ecma/injections.scm#L1-L6 **Before:** <img width="441" alt="Screenshot 2024-04-20 at 5 51 04 AM" src="https://github.com/zed-industries/zed/assets/20072509/8e77851d-22ad-4dc4-8e10-9ac558d3cf40"> **After:** <img width="441" alt="Screenshot 2024-04-20 at 5 52 05 AM" src="https://github.com/zed-industries/zed/assets/20072509/a607c219-6973-40c3-958c-44a003d008c3"> Release Notes: - Changed detection of JSDoc to only do syntax highlighting in block comments. Improved previous work done in #7826.
Closes #4926
Release Notes: