-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Disable binary downloads #14034
Conversation
Co-Authored-By: Mikayla <mikayla@zed.dev> Co-Authored-By: Marshall <marshall@zed.dev>
please document how distribution packagers can tell zed where to find the distro versions of the binaries/extensions that you want to use. so we can cover the needed dependencies with packaging. |
I think it would be actually nicer to show a notification when trying to download a binary, so the user can agree or disagree in that moment |
The Flatpak package would be a good place to demonstrate this |
This will be rolled into an additional and separate change, when we finish our extension system. |
Is there any particular reason why this setting is opt-out and not opt-in? It's interesting to see it being handled this way. Plus, looking at the current state, it seems like the user won't be able to choose whether to download missing binary packages or not, i.e., if you opt-out for automatic binary downloads you'll have to install them manually. Wouldn't a system like VS Code's be better in this case? Either block all downloads, or allow the user to choose if they want to download required binary packages for extensions when they first open a project (and have a third option to just install them automatically)? |
For future reference, this PR has not been abandoned. I got Covid shortly after the Linux launch, and haven't been able to write code for a while. This should be finished in the next few weeks, as I recover. We'll be incorporating the feedback here and in other places when we restart this work. |
fixes #12589 #12354
follow up to #12703
TODO:
Release Notes: