Fix an error in case of 'type' ctype param #1

Merged
merged 2 commits into from Jul 13, 2012

Conversation

Projects
None yet
4 participants
@jpochyla
Contributor

jpochyla commented Oct 12, 2011

Using a type Content-Type parameter results in:
EncodingError: Content-Type malformed, not allowed: 'multipart/related'; {'type': 'text/html'} (Python ERROR: __init__() got multiple values for keyword argument 'type'

This change is consistent with mail.MIMEBase.__init__ param names.

@teddziuba

This comment has been minimized.

Show comment Hide comment
@teddziuba

teddziuba Oct 13, 2011

Collaborator

I know this is super pedantic, but the Python style for variables that have the same name as keywords is to suffix with an underscore. Prefixing with an underscore signifies that the variable is a class private.

Collaborator

teddziuba commented Oct 13, 2011

I know this is super pedantic, but the Python style for variables that have the same name as keywords is to suffix with an underscore. Prefixing with an underscore signifies that the variable is a class private.

@kennethreitz

This comment has been minimized.

Show comment Hide comment
@kennethreitz

kennethreitz Oct 13, 2011

@teddziuba 👍

zedshaw added a commit that referenced this pull request Jul 13, 2012

Merge pull request #1 from jpochyla/patch-1
Fix an error in case of 'type' ctype param

@zedshaw zedshaw merged commit 6d9bf01 into zedshaw:master Jul 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment