Skip to content
This repository

Feature/fix sql statistics name column type #74

Merged
merged 1 commit into from over 2 years ago

2 participants

Markus Schirp Zed A. Shaw
Markus Schirp

Dunno if it has consequences for sqlite. But it is improving
consistency.

Markus Schirp Change 'text' to 'TEXT' in SQL column type def
Dunno if it has consequences for sqlite. But it is improving
consistency.
585ca8d
Zed A. Shaw
Owner

Bizarre, can you explain why that was necessary?

Zed A. Shaw zedshaw merged commit cc84d47 into from January 05, 2012
Zed A. Shaw zedshaw closed this January 05, 2012
Markus Schirp

As you know sqlite3 types have a type "affinity". When there was the "text" (downcase) I had a case this column had some kind of 'unknown or void' affinity. As I changed the definition to the uppercase "TEXT", the behavior was like TEXT affinity as expected. I cannot reproduce this anymore since I forgot the details. This change is 3 month old. Could be some ultra odd and edge case bug / behavior of my past sqlite3 / compiler / etc environment.

Markus Schirp
mbj commented January 05, 2012

As you know sqlite3 types have a type "affinity". When there was the "text" (downcase) I had a case this column had some kind of 'unknown or void' affinity. As I changed the definition to the uppercase "TEXT", the behavior was like TEXT affinity as expected. I cannot reproduce this anymore since I forgot the details. This change is 3 month old. Could be some ultra odd and edge case bug / behavior of my past sqlite3 / compiler / etc environment.

BTW: For some other obscure reason I managed to commend on commit rather than pull request. This is a repost...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Sep 21, 2011
Markus Schirp Change 'text' to 'TEXT' in SQL column type def
Dunno if it has consequences for sqlite. But it is improving
consistency.
585ca8d
This page is out of date. Refresh to see the latest.
2  examples/python/mongrel2/sql/config.sql
@@ -60,7 +60,7 @@ CREATE TABLE setting (id INTEGER PRIMARY KEY, key TEXT, value TEXT);
60 60
 CREATE TABLE statistic (id SERIAL,
61 61
     other_type TEXT,
62 62
     other_id INTEGER,
63  
-    name text,
  63
+    name TEXT,
64 64
     sum REAL,
65 65
     sumsq REAL,
66 66
     n INTEGER,
2  src/config/config.sql
@@ -61,7 +61,7 @@ CREATE TABLE setting (id INTEGER PRIMARY KEY, key TEXT, value TEXT);
61 61
 CREATE TABLE statistic (id SERIAL,
62 62
     other_type TEXT,
63 63
     other_id INTEGER,
64  
-    name text,
  64
+    name TEXT,
65 65
     sum REAL,
66 66
     sumsq REAL,
67 67
     n INTEGER,
2  tools/m2sh/src/constants.c
@@ -94,7 +94,7 @@ struct tagbstring CONFIG_SCHEMA = bsStatic(
94 94
 "CREATE TABLE statistic (id SERIAL, \n"
95 95
 "    other_type TEXT,\n"
96 96
 "    other_id INTEGER,\n"
97  
-"    name text,\n"
  97
+"    name TEXT,\n"
98 98
 "    sum REAL,\n"
99 99
 "    sumsq REAL,\n"
100 100
 "    n INTEGER,\n"
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.