Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethrow target exception of job worker invocation #57

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@menski
Copy link
Member

commented May 16, 2019

closes #56

@menski menski requested a review from jangalinski May 16, 2019

@menski

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

I would like to add a test case for this, but I'm not sure how to do this in the current test suites. Any pointers @jangalinski?

@codecov-io

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #57 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
- Coverage     14.88%   14.77%   -0.12%     
  Complexity       16       16              
============================================
  Files            30       30              
  Lines           262      264       +2     
  Branches         12       12              
============================================
  Hits             39       39              
- Misses          218      220       +2     
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...n/java/io/zeebe/spring/client/bean/MethodInfo.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00daa9...a52e579. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #57 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
- Coverage     14.88%   14.77%   -0.12%     
  Complexity       16       16              
============================================
  Files            30       30              
  Lines           262      264       +2     
  Branches         12       12              
============================================
  Hits             39       39              
- Misses          218      220       +2     
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...n/java/io/zeebe/spring/client/bean/MethodInfo.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00daa9...a52e579. Read the comment docs.

@jangalinski

This comment has been minimized.

Copy link
Collaborator

commented May 20, 2019

Not sure about the test cases, but I can tell you, that the lombok @SneakyThrows will take every checked exception and wrap it in a RuntimeException, so you possible would want to remove that annotation.
Which will possibly have impact on the lambda-style implementation ...

Could you add a pseudo code test scenario to the issue, then I can think about it ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.