New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can configure the elasticsearch exporter to use basic authentication #1341

Open
menski opened this Issue Sep 17, 2018 · 1 comment

Comments

2 participants
@menski
Copy link
Member

menski commented Sep 17, 2018

No description provided.

@menski menski added ready labels Sep 17, 2018

@menski menski added this to the Exporter milestone Sep 17, 2018

@npepinpe

This comment has been minimized.

Copy link
Member

npepinpe commented Sep 17, 2018

I ran into the same issue with MongoDB, i.e. how to handle secrets.

Right now all configuration takes place with configuration files, which isn't ideal for storing (most likely) unencrypted secrets.

Environment is an option, but that's a little more complicated if, say, you want to have 2 ES exporters, but they're both using the same env var. You'd need to configure which environment variable name to use I guess, e.g.:

[[exporters]]
id = "ES1"
# ...
  [exporters.args]
  userEnvVar = "ES_USERNAME_1"
  pwEnvVar = "ES_PASSWORD_1"
  # ...

[[exporters]]
id = "ES2"
# ...
  [exporters.args]
  userEnvVar = "ES_USERNAME_2"
  pwEnvVar = "ES_PASSWORD_2"
  # ...

I think environment variables are the most flexible in terms of plugging in to other secrets managing systems, e.g. vault or AWS parameter store. You can read those secrets when launching the instance and inject the correct environment (you could also create the config file with the correct params, but then you can't pre-packaged those files before launch I guess).

Either way, I think it makes sense to spend some time here on this, since whatever solution you come up with will probably be useful for many other exporters.

bors bot added a commit that referenced this issue Sep 19, 2018

Merge #1344
1344: Add elasticsearch exporter r=menski a=menski

- basic implementation for a generic elasticsearch exporter
- the exporter is currently added to the distribution to ease the getting started experience, this should be challenged in the near future
- the exporter might break the broker in case of an exception, we need to discuss the exception/error concept of exporters
- set deadline of job records to null if deadline is not set

closes #1326
workaround for #1334 

follow up issues #1341, #1342 and #1343


Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Co-authored-by: Sebastian Menski <sebastian@menski.org>

bors bot added a commit that referenced this issue Sep 19, 2018

Merge #1344
1344: Add elasticsearch exporter r=menski a=menski

- basic implementation for a generic elasticsearch exporter
- the exporter is currently added to the distribution to ease the getting started experience, this should be challenged in the near future
- the exporter might break the broker in case of an exception, we need to discuss the exception/error concept of exporters
- set deadline of job records to null if deadline is not set

closes #1326
workaround for #1334 

follow up issues #1341, #1342 and #1343


Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Co-authored-by: Sebastian Menski <sebastian@menski.org>

@menski menski removed the ready label Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment