Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follower snapshot replication verification #4425

Closed
Zelldon opened this issue Apr 30, 2020 · 1 comment · Fixed by #4641
Closed

Follower snapshot replication verification #4425

Zelldon opened this issue Apr 30, 2020 · 1 comment · Fixed by #4641
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@Zelldon
Copy link
Member

Zelldon commented Apr 30, 2020

Description

Currently in our normal snapshot replication we already have checksum validation, but unfortunately in the Leader to slow follower we haven't. This should be fixed via #4424 . After we merged this stuff and we implemented #4423 we should verify on receiving a snapshot chunk the checksum.

If the chunk is:

  • invalid: we should reject it and the leader should send it again - we expect that this can only happen due to network hickup's since it is was validated on leader side via Verify snapshot after taking one #4423 (note it is intended that we don't expect malicious users or corrupted hard disk for now, since it is less likely and it makes it more complex)
  • valid: all fine we write it to disk

After we received all chunks we verify the complete snapshot.
For now we postponed opening the database to use the integrity checks of RocksDB. We expect that our checksum should be enough, which means we either have a checksum of the complete snapshot or check all chunks again.

If this test results in:

  • invalid we mark the snapshot as invalid; as we currently do and wait for the next snapshot
  • valid we mark the snapshot as valid and commit this snapshot (move it to the right dir)

depends on #4423
depends on #4424

@Zelldon Zelldon added Status: In Progress kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog labels Apr 30, 2020
@Zelldon Zelldon self-assigned this Apr 30, 2020
@Zelldon Zelldon mentioned this issue Jun 9, 2020
3 tasks
@Zelldon
Copy link
Member Author

Zelldon commented Jun 9, 2020

This was done with #4641

@Zelldon Zelldon closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant