New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zbctl to Zeebe distribution #544

Closed
menski opened this Issue Nov 14, 2017 · 2 comments

Comments

1 participant
@menski
Member

menski commented Nov 14, 2017

  • zbctl for linux and windows (64-bit) is included in zeebe-distribution bin folder
  • requires zbctl to be release before Zeebe release
  • options for packaging

@menski menski added the ci label Nov 14, 2017

@menski menski self-assigned this Nov 14, 2017

@menski menski added release labels Nov 14, 2017

@menski menski added in progress and removed ready labels Mar 1, 2018

@menski

This comment has been minimized.

Member

menski commented Mar 1, 2018

Approach:

  • add zbctl release to Jenkins pipeline
    • remove zbctl release from travis.yml in zbc-go repository
    • install go and goreleaser as precondition of Jenkins job
    • checkout zbc-go to ${workspace}/gopath/src/github.com/zeebe-io/zbc-go
    • set GOPATH to ${workspace}/gopath
    • create a new tag for the release version
    • push git tag if not testing, i.e. PUSH_CHANGES is true
    • run goreleaser (optionally with --skip-publish for testing)
  • Zeebe dist pom contains ant tasks to copy zbctl amd64 binaries for linux, windows and darwin
    • zbctl for darwin is renamed to zbctl.darwin
    • binaries are made executable to everyone
    • distro build does not require zbctl binaries to be available, i.e. SNAPSHOT builds will not contain zbctl for now

menski added a commit to zeebe-io/zbc-go that referenced this issue Mar 1, 2018

chore(travis): remove release step from travis.yml
- release will be build by jenkins from now on

related to zeebe-io/zeebe#544
@menski

This comment has been minimized.

Member

menski commented Mar 1, 2018

We also have to adjust the release wiki page after this change as no manual zbc release is necessary anymore, but now zbc is our first release dependency. Which means if the Go client is not ready the release cannot be started.

menski added a commit that referenced this issue Mar 1, 2018

chore(dist): copy zbctl to bin folder of distribution
- copy linux/windows/darwin amd64 binaries to distribution bin folder if they
  exist
- rename zbctl darwin binary to zbctl.darwin
- set all zbctl binaries to executable
- do not fail if zbctl binaries don't exists, i.e. during SNAPSHOT build

related to #544

menski added a commit to zeebe-io/zbc-go that referenced this issue Mar 1, 2018

chore(travis): remove release step from travis.yml
- release will be build by jenkins from now on

related to zeebe-io/zeebe#544

@menski menski closed this Mar 1, 2018

@menski menski removed the in progress label Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment