Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 0.23] Don't update exporter position to smaller value #5528

Merged
merged 2 commits into from Oct 12, 2020
Merged

[Backport 0.23] Don't update exporter position to smaller value #5528

merged 2 commits into from Oct 12, 2020

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Oct 7, 2020

Description

Backports #5462

Related issues

closes #5294

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@Zelldon
chore(broker): extract ExporterContainer
98b912b 
 * create separate class for the ExporterContainer and logic of setting exporter positions etc
 * make it possible to test how position are set
 * add new test class to test ExporterContainer
@Zelldon Zelldon force-pushed the zell-backport-23-fix-exporter branch from deaf0d1 to 98b912b Compare October 8, 2020 12:37
deepthidevaki
deepthidevaki approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Zelldon
Copy link
Member Author

Zelldon commented Oct 12, 2020

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Oct 12, 2020

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 8efd828 into stable/0.23 Oct 12, 2020
@zeebe-bors zeebe-bors bot deleted the zell-backport-23-fix-exporter branch October 12, 2020 08:48
@deepthidevaki deepthidevaki mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zelldon @deepthidevaki