Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1040: Add zero-indexed version of str_split #1049

Merged
merged 1 commit into from Jul 7, 2020

Conversation

timwoj
Copy link
Contributor

@timwoj timwoj commented Jul 6, 2020

Fixes #1040

I'm not entirely sure that &deprecated attribute is working as expected though, as the btest doesn't output anything around the usage of it. I'll open a separate issue to investigate that.

@timwoj timwoj force-pushed the topic/timw/1040-str-split branch from 2dcdb60 to 53a2ef8 Compare July 6, 2020 23:10
@timwoj
Copy link
Contributor Author

timwoj commented Jul 6, 2020

Scratch that bit about the attribute, that was just be being dumb 😄

@timwoj timwoj force-pushed the topic/timw/1040-str-split branch from 53a2ef8 to e6871ed Compare July 7, 2020 00:05
@jsiwek jsiwek self-assigned this Jul 7, 2020
@jsiwek jsiwek added this to Unassigned / Todo in Release 3.2.0 via automation Jul 7, 2020
@jsiwek jsiwek added this to the 3.2.0 milestone Jul 7, 2020
jsiwek added a commit to zeek/zeek-docs that referenced this pull request Jul 7, 2020
@jsiwek jsiwek merged commit 7b15b82 into master Jul 7, 2020
Release 3.2.0 automation moved this from Unassigned / Todo to Done Jul 7, 2020
@timwoj timwoj deleted the topic/timw/1040-str-split branch July 28, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 3.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

str_split always returns a vector with the first element missing
2 participants