New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate redundant frame/call stack tracking #210

Open
jsiwek opened this Issue Nov 14, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jsiwek
Copy link
Member

jsiwek commented Nov 14, 2018

Both these seem to accomplish the same thing:

https://github.com/bro/bro/blob/f31204c7c55a87479f36b7f1195c8f5323330904/src/Func.cc#L53
https://github.com/bro/bro/blob/f31204c7c55a87479f36b7f1195c8f5323330904/src/Frame.cc#L10

The later is maybe more general so can try consolidating to that.

Another enhancement may be to wrap accesses/modifications to that frame stack in a new thread-safe API/structure. Reason being that it's otherwise difficult for plugins to passively observe/sample the script-layer call stack (can't use a BIF because that changes call stack, can't use hooks in main thread because it's also important to know how much time is not spent in script-layer, so naturally would turn to requiring thread-safe access from external plugin thread).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment