New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeek renaming: script file suffixes #237

Open
jsiwek opened this Issue Jan 11, 2019 · 9 comments

Comments

Projects
None yet
8 participants
@jsiwek
Copy link
Member

jsiwek commented Jan 11, 2019

I think we can at least rename scripts distributed with Zeek to use a different suffix other than .bro. What to use instead? .zeek or .zk ? I prefer .zk as it's shorter.

I don't recall what all internal logic depends on the file extension, maybe some file searching logic, but that would need to change.

Do we treat .bro as something that's deprecated and to be removed/unsupported later? External packages could possibly want to use .bro for a prolonged time simply for compatibility reasons.

@JonZeolla

This comment has been minimized.

Copy link
Collaborator

JonZeolla commented Jan 11, 2019

Maybe it's just me but I think zookeeper with .zk, I would prefer zeek. Also with a rename project as big as this, uniformity will make it easier to pick up for new people.

@vpax

This comment has been minimized.

Copy link
Contributor

vpax commented Jan 11, 2019

Well FWIW .zk appeals to me more than .zeek. Any extension > 3 characters long looks a bit funny to my eye. Surfing around just now, I don't see much mention of .zk files. (Ironically, I do find that .bro clashes with a Broderbund format - perhaps telling that the conflict has never come up in practice, as far as I now.)

@sethhall

This comment has been minimized.

Copy link
Member

sethhall commented Jan 22, 2019

I prefer .zeek fwiw.

@0xxon

This comment has been minimized.

Copy link
Member

0xxon commented Jan 22, 2019

And I kind of like .zk more (and don't think the conflict with zookeper is a big problem).

@vpax

This comment has been minimized.

Copy link
Contributor

vpax commented Jan 22, 2019

I know pretty much everyone is going to hate this suggestion, but: we could just accept & use both by convention. After all, we're already going to have .bro for quite a while.

@JonZeolla

This comment has been minimized.

Copy link
Collaborator

JonZeolla commented Jan 22, 2019

I agree with @jsiwek's thought to deprecate .bro and suggest keeping it around for at least two releases. I don't think the zookeeper conflict is a big problem (just a potential problem), and they don't necessarily use a .zk file extension in zookeeper that I'm aware of regardless, it's just a bit confusing.

@hosom

This comment has been minimized.

Copy link
Contributor

hosom commented Jan 22, 2019

I think .zk is unlikely to ever come up as an issue. I think .zeek is completely reasonable, but agree with @vpax in that I don't love any file extension > 3 characters.

Accepting and using both is a great idea and it made me think of something else... Why not use explicit file names for loads and set .zk and .zeek as a standard?

@rsmmr

This comment has been minimized.

Copy link
Member

rsmmr commented Jan 23, 2019

I like .zeek the most. Advantage of a short name is that it works as an extension!

I wouldn't standardize on two new extensions, though, that just seems confusing.

@mavam

This comment has been minimized.

Copy link
Member

mavam commented Jan 23, 2019

I also like .zeek the best. If we were pioneering in the lands of 4-letter extensions, I'd be hesitant. But there already exists the ubiquitous .docx extension and a few related others. So people would be used to seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment