Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing "when" support for monitoring globals #319

Open
rsmmr opened this Issue Mar 31, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@rsmmr
Copy link
Member

rsmmr commented Mar 31, 2019

The when statement supports waiting for globals to change their value, to then trigger the statement's body. That's nice functionality in principle, but it comes with quite a bit of internal complexity and performance impact. In particular, this functionality creates a dependency on a significant chunk of code that we could otherwise take out as we remove the deprecated old communication & serialization logic.

I think it's worth reconsidering if this functionality worth keeping. My guess is that not many scripts are actually using it; and that those which do, would probably not face major challenges finding an alternative approach.

To understand this better, two research tasks:

  • Examine existing scripts & packages for use of this feature
  • Collect feedback on mailing list whether this is worth keeping

(Note: To be clear, this is not about removing the when statement altogether; we'd keep it for blocking function calls, like DNS lookups and Broker communication. Function calls are pretty certainly the main use cases of the statement in existing scripts.)

@jsiwek jsiwek added this to the 2.7 milestone Apr 1, 2019

@rsmmr rsmmr self-assigned this Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.