Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeek renaming: environment variables #339

Closed
jsiwek opened this issue Apr 16, 2019 · 3 comments

Comments

@jsiwek
Copy link
Member

commented Apr 16, 2019

For any BRO-prefixed environment variables we use (get a list from --help output and/or grepping getenv usages), need to accept/prefer a ZEEK-prefixed version.

@jsiwek jsiwek added this to the 3.0.0 milestone Apr 16, 2019

@jsiwek jsiwek added this to Unassigned / To Do in Zeek Renaming Tasks via automation Apr 16, 2019

@jsiwek jsiwek removed the Task: Renaming label May 13, 2019

@jsiwek jsiwek added this to Unassigned / Todo in Release 3.0.0 via automation May 13, 2019

@dnthayer

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Zeek uses these: BROPATH, BRO_PLUGIN_PATH, BRO_PLUGIN_ACTIVATE,
BRO_PREFIXES, BRO_DNS_FAKE, BRO_SEED_FILE, BRO_LOG_SUFFIX,
BRO_PROFILER_FILE, BRO_DISABLE_BROXYGEN, BRO_DEFAULT_CONNECT_RETRY,
BRO_BROKER_MAX_THREADS, BRO_DEFAULT_LISTEN_ADDRESS,
BRO_DEFAULT_LISTEN_RETRY.
Also, the Zeek system_env BIF creates BRO_ARG_* environment variables.
The zeek-cut tool uses BRO_CUT_TIMEFMT.

@dnthayer

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Branch "topic/dnthayer/gh-339" in the zeek, zeek-aux, zeek-docs, and zeekctl git repos
contains the changes needed to rename all BRO-prefixed env. vars.

@dnthayer dnthayer moved this from Unassigned / To Do to Assigned / In Progress in Zeek Renaming Tasks May 22, 2019

@dnthayer dnthayer moved this from Unassigned / Todo to Assigned / In Progress in Release 3.0.0 May 23, 2019

jsiwek added a commit that referenced this issue May 24, 2019

Merge remote-tracking branch 'origin/topic/dnthayer/gh-339'
* origin/topic/dnthayer/gh-339:
  Rename all BRO-prefixed environment variables
@jsiwek

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Fixed via #374 (thanks, Daniel).

Also added a centralized getenv wrapper function in case we ever want to emit deprecation warnings for use of the old env. vars.

@jsiwek jsiwek closed this May 24, 2019

Zeek Renaming Tasks automation moved this from Assigned / In Progress to Done May 24, 2019

Release 3.0.0 automation moved this from Assigned / In Progress to Done May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.