Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UTF-8 in ASCII logs #458

Open
timwoj opened this issue Jul 9, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@timwoj
Copy link
Contributor

commented Jul 9, 2019

As a follow-on to the work for #150, we should also support UTF-8 output in regular ASCII logs.

@devbali

This comment has been minimized.

Copy link

commented Jul 11, 2019

I can give this a stab, since this is not a show-stopper. You are talking about simply escaping utf-8 in logs, as enabled by customisation features from zeek scripts?

@devbali devbali self-assigned this Jul 11, 2019

@0xxon

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Probably the other way round - currently UTF8 is always escaped in log-files. Not escaping valid UTF8 would be the new feature.

@timwoj

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@devbali I'm just waiting on the JSON stuff to land that's in PR. There's already a method there to do the escaping so it should just be a matter of calling it from the right places in the ASCII logger.

@devbali devbali assigned devbali and unassigned devbali Jul 11, 2019

@rsmmr

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

@devbali

This comment has been minimized.

Copy link

commented Jul 15, 2019

Yeah, I did not know about the byte data type in zeek. I am adding that into the current set up right now.

@timwoj

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@rsmmr There was some chatter in slack about it. We decided was to just remove the escaping altogether for ascii logs, since it would already be escaped by the utf8 method. It needs heavy testing though to make sure it didn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.