Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MemoryAllocation()? #572

Open
rsmmr opened this issue Sep 9, 2019 · 1 comment

Comments

@rsmmr
Copy link
Member

commented Sep 9, 2019

A number of classes have MemoryAllocation() methods that try to estimate the actual memory usage of an instance, taking things like padding by the allocator into account. However, it's unclear if this logic still works: it has neither been validated in a long time nor I believe consistently updated with code changes. It's also not portable to begin with due to assumptions about specifics of the allocator. I suggest we investigate to which degree people are still relying on the numbers this computes and consider removing it.

@sethhall

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I've also been suspect of this functionality for a long time and I think it makes sense to remove it. I'd be surprised to discover if anyone is using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.