Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read TCP option values #618

Closed
phillipa opened this issue Oct 3, 2019 · 1 comment · Fixed by #621

Comments

@phillipa
Copy link

commented Oct 3, 2019

It would be nice if the tcp_options event (https://docs.zeek.org/en/stable/scripts/base/bif/plugins/Zeek_TCP.events.bif.zeek.html#id-tcp_option )
would allow the code to read the value of the given TCP option.

@jsiwek jsiwek self-assigned this Oct 3, 2019
jsiwek added a commit to zeek/zeek-docs that referenced this issue Oct 4, 2019
jsiwek added a commit that referenced this issue Oct 4, 2019
@jsiwek jsiwek added this to Unassigned / Todo in Release 3.1.0 via automation Oct 4, 2019
@jsiwek jsiwek added this to the 3.1.0 milestone Oct 4, 2019
@jsiwek

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

In #621, I added a new tcp_options event rather than alter the old one. It contains the full list of TCP options along with their values. Let me know if there's other things to include in the event that would be useful.

@jsiwek jsiwek moved this from Unassigned / Todo to Pending Review / Merge in Release 3.1.0 Oct 9, 2019
0xxon added a commit that referenced this issue Oct 15, 2019
…alues'

* origin/topic/jsiwek/gh-618-tcp-option-values:
  Add weirds for invalid TCP option lengths
  GH-618: add "tcp_options" event containing TCP option values
  Fix tcp_option event
@0xxon 0xxon closed this in #621 Oct 15, 2019
Release 3.1.0 automation moved this from Pending Review / Merge to Done Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 3.1.0
  
Done
3 participants
You can’t perform that action at this time.